Sam Rolfe
14b304e0b0
- internal/mqtt: publish each device's desired state retained on restrict/<device>/config; subscribe to restrict/+/status and restrict/+/telemetry and write reports to SQLite; publish on every state change, republish on connect and every 15 minutes from SQLite, so the broker is repaired from the source of truth. - store: presence (devices.online and last_seen, audited only on transitions), telemetry upsert per (device, day, app, domain) via migration 002, allow and block lists read into the config payload, device lookup by topic. - config: MQTT settings. TLS plus per-device credentials are required; the pre-TLS shared broker needs an explicit CONTROL_MQTT_INSECURE escape hatch. - web: republish config after lock, unlock, expiry, create and edit; broker card on the status partial. - deploy/mosquitto: TLS listener, topic ACL, credential provisioning and a verifier that proves the policy on a throwaway broker. Not applied to the shared Mosquitto on .13 — that change needs Sam's approval. - cmd/control: mqtt-clients prints the MQTT identity of every device. - paho.mqtt.golang v1.5.1, which pulls golang.org/x/net and with it the golang.org/x/crypto bump to v0.42.0. Verified on .13: retained config delivered to a fresh subscriber; a client killed without DISCONNECT drove the broker's retained will and the service flipped the device offline; telemetry landed in SQLite; make mqtt-verify passed 13/13; the service connected over TLS with credentials and a CA. Co-Authored-By: Paperclip <noreply@paperclip.ing>
109 lines
3.2 KiB
Go
109 lines
3.2 KiB
Go
package config
|
|
|
|
import (
|
|
"log/slog"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestLoadDefaultsAndValidation(t *testing.T) {
|
|
t.Setenv("CONTROL_SESSION_SECRET", "0123456789abcdef")
|
|
t.Setenv("CONTROL_ADMIN_PASSWORD", "hunter2")
|
|
t.Setenv("CONTROL_ADDR", "")
|
|
t.Setenv("CONTROL_DB_PATH", "")
|
|
// The lab broker has no TLS listener yet, so the pre-TLS escape hatch is
|
|
// the current deployment default (see CONTROL_MQTT_INSECURE).
|
|
t.Setenv("CONTROL_MQTT_INSECURE", "true")
|
|
|
|
cfg, err := Load()
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.Addr != ":8791" {
|
|
t.Errorf("Addr = %q, want :8791", cfg.Addr)
|
|
}
|
|
if cfg.DBPath != "/data/control.db" {
|
|
t.Errorf("DBPath = %q, want /data/control.db", cfg.DBPath)
|
|
}
|
|
if cfg.AdminUsername != "sam" {
|
|
t.Errorf("AdminUsername = %q, want sam", cfg.AdminUsername)
|
|
}
|
|
if cfg.SessionTTL != 12*time.Hour {
|
|
t.Errorf("SessionTTL = %v, want 12h", cfg.SessionTTL)
|
|
}
|
|
if cfg.LogLevel != slog.LevelInfo {
|
|
t.Errorf("LogLevel = %v, want info", cfg.LogLevel)
|
|
}
|
|
if !cfg.CookieSecure {
|
|
t.Error("CookieSecure = false, want true by default")
|
|
}
|
|
}
|
|
|
|
func TestLoadRequiresSecretAndPassword(t *testing.T) {
|
|
t.Setenv("CONTROL_SESSION_SECRET", "")
|
|
t.Setenv("CONTROL_ADMIN_PASSWORD", "hunter2")
|
|
if _, err := Load(); err == nil {
|
|
t.Error("expected error when session secret is missing")
|
|
}
|
|
|
|
t.Setenv("CONTROL_SESSION_SECRET", "0123456789abcdef")
|
|
t.Setenv("CONTROL_ADMIN_PASSWORD", "")
|
|
t.Setenv("CONTROL_ADMIN_PASSWORD_HASH", "")
|
|
if _, err := Load(); err == nil {
|
|
t.Error("expected error when no admin password is set")
|
|
}
|
|
}
|
|
|
|
func TestMQTTDefaultsAndGuards(t *testing.T) {
|
|
t.Setenv("CONTROL_SESSION_SECRET", "0123456789abcdef")
|
|
t.Setenv("CONTROL_ADMIN_PASSWORD", "hunter2")
|
|
|
|
// Enabled by default, pointed at the shared Mosquitto on `.13`.
|
|
t.Setenv("CONTROL_MQTT_INSECURE", "true")
|
|
cfg, err := Load()
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if !cfg.MQTTEnabled {
|
|
t.Error("MQTTEnabled = false, want true by default")
|
|
}
|
|
if cfg.MQTTBroker != DefaultMQTTBroker {
|
|
t.Errorf("MQTTBroker = %q, want %q", cfg.MQTTBroker, DefaultMQTTBroker)
|
|
}
|
|
if cfg.MQTTTLS() {
|
|
t.Error("MQTTTLS = true for the default plaintext broker, want false")
|
|
}
|
|
|
|
// Without the escape hatch, a plaintext credential-less broker is refused
|
|
// (AGENTS.md §10 rule 6).
|
|
t.Setenv("CONTROL_MQTT_INSECURE", "false")
|
|
if _, err := Load(); err == nil {
|
|
t.Error("expected an error for a plaintext broker without CONTROL_MQTT_INSECURE")
|
|
}
|
|
|
|
// TLS plus credentials is the supported shape.
|
|
t.Setenv("CONTROL_MQTT_BROKER", "tls://mosquitto.lab.audasmedia.com.au:8883")
|
|
t.Setenv("CONTROL_MQTT_USERNAME", "control-service")
|
|
t.Setenv("CONTROL_MQTT_PASSWORD", "secret")
|
|
cfg, err = Load()
|
|
if err != nil {
|
|
t.Fatalf("Load with TLS: %v", err)
|
|
}
|
|
if !cfg.MQTTTLS() {
|
|
t.Error("MQTTTLS = false for a tls:// broker, want true")
|
|
}
|
|
|
|
// MQTT can be switched off entirely.
|
|
t.Setenv("CONTROL_MQTT_ENABLED", "false")
|
|
t.Setenv("CONTROL_MQTT_BROKER", "")
|
|
t.Setenv("CONTROL_MQTT_USERNAME", "")
|
|
t.Setenv("CONTROL_MQTT_PASSWORD", "")
|
|
cfg, err = Load()
|
|
if err != nil {
|
|
t.Fatalf("Load with MQTT disabled: %v", err)
|
|
}
|
|
if cfg.MQTTEnabled {
|
|
t.Error("MQTTEnabled = true, want false when CONTROL_MQTT_ENABLED=false")
|
|
}
|
|
}
|