Fix transposed test number: +61 423 274 487 (61423274487) everywhere
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
## Context
|
||||
|
||||
Phase 1 (frontend-foundation, merged) gives us auth, tag setup/management, and the public tag page with `tel:` links. Phase 2 adds the finder-facing scan flow and owner alerts. Confirmed with the owner: SMS provider is **SMSGlobal** (MXT), using their **shared/pooled sender number** (origin blank — upgrade to a registered sender later); real test number `+61432374487`. The `scans` table already exists; it needs no new columns.
|
||||
Phase 1 (frontend-foundation, merged) gives us auth, tag setup/management, and the public tag page with `tel:` links. Phase 2 adds the finder-facing scan flow and owner alerts. Confirmed with the owner: SMS provider is **SMSGlobal** (MXT), using their **shared/pooled sender number** (origin blank — upgrade to a registered sender later); real test number `+61423274487`. The `scans` table already exists; it needs no new columns.
|
||||
|
||||
## Goals / Non-Goals
|
||||
|
||||
@@ -59,7 +59,7 @@ Phase 1 (frontend-foundation, merged) gives us auth, tag setup/management, and t
|
||||
|
||||
1. Re-apply `db/schema.sql` (idempotent ALTER) on the existing dev DB; regenerate sqlc queries.
|
||||
2. Land code with log sender; run automated suite (no real SMS).
|
||||
3. Manual check: one real SMS to `+61432374487` with real credentials from `.13`-safe env (local run, then removed).
|
||||
3. Manual check: one real SMS to `+61423274487` with real credentials from `.13`-safe env (local run, then removed).
|
||||
|
||||
## Open Questions
|
||||
|
||||
|
||||
@@ -12,7 +12,7 @@ Phase 1 built the foundation (auth, tag setup, public page), but the core produc
|
||||
- **Finder contact**: finder can leave their mobile → stored in `scans.scanner_phone` → owner is SMS'd with the finder's number.
|
||||
- **`sms:` link** on the tag page (prefilled message asking the finder for their number).
|
||||
- **Branding**: "WhereWoof" → **"Where Woof"**, page title **"Where Woof !"** (play on *werewolf*).
|
||||
- Provider detail (confirmed with owner): SMSGlobal, **pooled/shared sender number** (origin blank; upgrade to registered sender later), real test number `+61432374487`.
|
||||
- Provider detail (confirmed with owner): SMSGlobal, **pooled/shared sender number** (origin blank; upgrade to registered sender later), real test number `+61423274487`.
|
||||
|
||||
## Capabilities
|
||||
|
||||
|
||||
@@ -41,7 +41,7 @@ SMS sending SHALL go through an abstraction so that automated tests and developm
|
||||
- **THEN** sending an alert logs the message instead of calling the provider
|
||||
|
||||
### Requirement: International number format
|
||||
Phone numbers SHALL be normalised to international format without a leading `+` or leading zero before sending (e.g. `+61432374487` or `0432374487` → `61432374487`).
|
||||
Phone numbers SHALL be normalised to international format without a leading `+` or leading zero before sending (e.g. `+61423274487` or `0432374487` → `61423274487`).
|
||||
|
||||
#### Scenario: Number normalisation
|
||||
- **WHEN** an owner or finder number is stored in any local format
|
||||
|
||||
@@ -23,5 +23,5 @@
|
||||
|
||||
- [x] 5.1 Extend the HTTP suite (`/tmp/verify.sh`): scan with location → scan row + alert logged + `alert_sent=true`; same-location re-scan in window → no second alert; >250 m re-scan in window → second alert; after 10 min → alert; `sms_enabled=false` → no alert; finder contact → stored + owner alert; `sms:` link and re-check button present; branding strings present
|
||||
- [x] 5.2 Unit test haversine (known distances) + NormalizeAU cases
|
||||
- [x] 5.3 Manual real-SMS check to `+61432374487` (real credentials, then removed)
|
||||
- [x] 5.3 Manual real-SMS check to `+61423274487` (real credentials, then removed)
|
||||
- [x] 5.4 `openspec validate scan-flow`; commit
|
||||
|
||||
Reference in New Issue
Block a user