feat: confirm playback from the media session, and stop demoting the top row
Phase 3 DoD reached end to end: `artemis run spotify_play query="Rolling Stones Honky Tonk"` played the right song in 13 steps / 35.3s, with playback paused first so the pass proves the row tap started it. Two things stopped it before that, both found on the real phone: - The playback check asserted on an on-screen "Pause" label that Spotify never shows: its transport button keeps the label "Play" while music is playing. The recipe now ends with a `playing` step that reads the app's media session (state PLAYING) and confirms the track title contains the query words. A failure reports the state and the track it found. - tap_row pressed the wrong row. Once a track is loaded its row carries a `Paused` state indicator, and counting that content description as row text dropped the top hit below an identical duplicate further down, so the tap went to y=1443 instead of y=878. Rows are now scored on their title and subtitle only (state lives in content descriptions), and scores within rowScoreTolerance are treated as equal so the higher row wins, because Spotify already ranks by relevance. internal/ui/rows_test.go reproduces that results screen, including the state indicator and the duplicate row. docs/phase-3-spotify-recipe.md records the successful run, the independent media-session and audio-output reads, and the failure that preceded it.
This commit is contained in:
@@ -158,7 +158,7 @@ func TestSpotifyRecipeIsValid(t *testing.T) {
|
||||
}
|
||||
}
|
||||
// The recipe must confirm it is in Spotify before it trusts a text match,
|
||||
// and it must wait for playback rather than assume it.
|
||||
// and it must confirm playback rather than assume it.
|
||||
var sawForeground bool
|
||||
for _, s := range rec.Steps {
|
||||
if s.Verb == "foreground" {
|
||||
@@ -169,8 +169,8 @@ func TestSpotifyRecipeIsValid(t *testing.T) {
|
||||
t.Fatal("spotify_play must pin the foreground app before matching text")
|
||||
}
|
||||
last := rec.Steps[len(rec.Steps)-1]
|
||||
if last.Verb != "wait" || last.Args[0] != "Pause" {
|
||||
t.Fatalf("the last step must confirm playback, got %+v", last)
|
||||
if last.Verb != "playing" || last.Args[0] != "{query}" {
|
||||
t.Fatalf("the last step must confirm the right track is playing, got %+v", last)
|
||||
}
|
||||
if last.Retry < 1 {
|
||||
t.Fatal("the playback check must be allowed to press the row again")
|
||||
@@ -209,16 +209,16 @@ func TestLoadAndList(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestRetryOnWait(t *testing.T) {
|
||||
rec, err := Parse("steps:\n - tap_row \"{query}\" 40s\n - wait exact \"Pause\" 45s retry 3\n")
|
||||
rec, err := Parse("steps:\n - tap_row \"{query}\" 40s\n - wait exact \"Search\" 45s retry 3\n")
|
||||
if err != nil {
|
||||
t.Fatalf("Parse: %v", err)
|
||||
}
|
||||
wait := rec.Steps[1]
|
||||
if wait.Retry != 3 || wait.Timeout != 45*time.Second || !wait.Exact || wait.Args[0] != "Pause" {
|
||||
if wait.Retry != 3 || wait.Timeout != 45*time.Second || !wait.Exact || wait.Args[0] != "Search" {
|
||||
t.Fatalf("retry wait step = %+v", wait)
|
||||
}
|
||||
// retry without a duration still works.
|
||||
rec, err = Parse("steps:\n - tap_row \"x\"\n - wait \"Pause\" retry 2\n")
|
||||
rec, err = Parse("steps:\n - tap_row \"x\"\n - wait \"Search\" retry 2\n")
|
||||
if err != nil {
|
||||
t.Fatalf("Parse: %v", err)
|
||||
}
|
||||
@@ -230,6 +230,7 @@ func TestRetryOnWait(t *testing.T) {
|
||||
func TestRetryRejectsBadUse(t *testing.T) {
|
||||
for name, src := range map[string]string{
|
||||
"on a tap": "steps:\n - tap \"x\" retry 3\n",
|
||||
"on tap_row": "steps:\n - tap_row \"x\" retry 3\n",
|
||||
"no number": "steps:\n - tap_row \"x\"\n - wait \"y\" retry\n",
|
||||
"zero": "steps:\n - tap_row \"x\"\n - wait \"y\" retry 0\n",
|
||||
"not a number": "steps:\n - tap_row \"x\"\n - wait \"y\" retry soon\n",
|
||||
@@ -240,6 +241,17 @@ func TestRetryRejectsBadUse(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestPlayingStep(t *testing.T) {
|
||||
rec, err := Parse("app: com.spotify.music\nsteps:\n - tap_row \"{query}\"\n - playing \"{query}\" 30s retry 3\n")
|
||||
if err != nil {
|
||||
t.Fatalf("Parse: %v", err)
|
||||
}
|
||||
p := rec.Steps[1]
|
||||
if p.Verb != "playing" || p.Args[0] != "{query}" || p.Timeout != 30*time.Second || p.Retry != 3 {
|
||||
t.Fatalf("playing step = %+v", p)
|
||||
}
|
||||
}
|
||||
|
||||
func TestForegroundStep(t *testing.T) {
|
||||
rec, err := Parse("app: com.spotify.music\nsteps:\n - launch\n - foreground 30s\n")
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user