sam/artemis_control
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: detect a wedged app with expect_change

Browse Source 
An app can stop consuming input while it keeps drawing: Android delivers
the tap, the app never acts on it. Phase 3 hit this three times against
Spotify and the recipe failed on the label it was waiting for, which names
the wrong problem.

The new `expect_change <duration>` step fingerprints the screen (foreground
package plus every visible label and its bounds) and fails when the screen
does not change after the previous step, with the distinct reason
"the app stopped consuming input". It supports `retry N`, which re-presses
the step above a bounded number of times, so a dropped tap is still
recovered and a wedged app still ends the run (FR-11).

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Sam Rolfe
2026-10-16 15:56:59 +11:00
parent 36b4dd2391
commit 43cd4282d0
6 changed files with 214 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/recipe/engine.go
View File

@@ -273,6 +273,18 @@ func executeStep(r *adb.Runner, rec *Recipe, step Step, index int, params map[st
sr.Detail = fmt.Sprintf("%q is gone", args[0])
return nil
case "expect_change":
// The wedged-app check. An app that has stopped consuming input
// still draws its old screen, so a delivered tap or key changes
// nothing. Failing here names the real problem instead of blaming
// the label the next step would have waited for (Phase 5).
_, _, err := ui.ExpectChange(r, timeout)
if err != nil {
return describeFailure(r, rec, fmt.Errorf("the app stopped consuming input: %w", err))
}
sr.Detail = "screen changed"
return nil
case "tap":
return tapByText(r, rec, args[0], step.Exact, timeout, &sr)

37
internal/recipe/recipe.go
View File

@@ -40,6 +40,8 @@
// title matches the text; with no text, wait for PLAYING
// alone (a radio plays a different track every few minutes)
// - wait_gone "Recents" 30s wait until no element matches the text
// - expect_change 10s fail unless the screen changes within the time
// (the wedged-app check: a delivered input that the app never acts on)
// - tap "Search" tap the element whose text matches (FR-4)
// - tap exact "Pause" tap an element whose text matches exactly
// - tap_if "Clear search query" tap it when it is on screen, else skip
@@ -140,21 +142,22 @@ var verbs = map[string]struct {
durArg bool // the single argument is a duration
allowExact bool
}{
"launch": {0, 1, false, false},
"foreground": {0, 1, false, false},
"wait": {1, 2, false, true},
"playing": {0, 2, false, false},
"wait_gone": {1, 2, false, true},
"tap": {1, 2, false, true},
"tap_if": {1, 1, false, true},
"tap_row": {1, 2, false, true},
"menu_row": {1, 2, false, false},
"scroll": {1, 1, false, false},
"type": {1, 1, false, false},
"key": {1, 1, false, false},
"back": {0, 0, false, false},
"home": {0, 0, false, false},
"sleep": {1, 1, true, false},
"launch": {0, 1, false, false},
"foreground": {0, 1, false, false},
"wait": {1, 2, false, true},
"playing": {0, 2, false, false},
"wait_gone": {1, 2, false, true},
"expect_change": {1, 1, true, false},
"tap": {1, 2, false, true},
"tap_if": {1, 1, false, true},
"tap_row": {1, 2, false, true},
"menu_row": {1, 2, false, false},
"scroll": {1, 1, false, false},
"type": {1, 1, false, false},
"key": {1, 1, false, false},
"back": {0, 0, false, false},
"home": {0, 0, false, false},
"sleep": {1, 1, true, false},
}
// keyNames are the key event names a recipe may use.
@@ -367,8 +370,8 @@ func parseStep(body string, lineNo int) (*Step, error) {
if err != nil || n < 1 {
return nil, fmt.Errorf("line %d: retry needs a positive number, got %q", lineNo, args[i+1])
}
if verb != "wait" && verb != "playing" {
return nil, fmt.Errorf("line %d: retry is only allowed on a wait or playing step", lineNo)
if verb != "wait" && verb != "playing" && verb != "expect_change" {
return nil, fmt.Errorf("line %d: retry is only allowed on a wait, playing or expect_change step", lineNo)
}
step.Retry = n
args = append(args[:i], args[i+2:]...)

31
internal/recipe/recipe_test.go
View File

@@ -230,11 +230,12 @@ func TestRetryOnWait(t *testing.T) {
func TestRetryRejectsBadUse(t *testing.T) {
for name, src := range map[string]string{
"on a tap": "steps:\n - tap \"x\" retry 3\n",
"on tap_row": "steps:\n - tap_row \"x\" retry 3\n",
"no number": "steps:\n - tap_row \"x\"\n - wait \"y\" retry\n",
"zero": "steps:\n - tap_row \"x\"\n - wait \"y\" retry 0\n",
"not a number": "steps:\n - tap_row \"x\"\n - wait \"y\" retry soon\n",
"on a tap": "steps:\n - tap \"x\" retry 3\n",
"on tap_row": "steps:\n - tap_row \"x\" retry 3\n",
"no number": "steps:\n - tap_row \"x\"\n - wait \"y\" retry\n",
"zero": "steps:\n - tap_row \"x\"\n - wait \"y\" retry 0\n",
"not a number": "steps:\n - tap_row \"x\"\n - wait \"y\" retry soon\n",
"expect_change without a duration": "steps:\n - key enter\n - expect_change\n",
} {
if _, err := Parse(src); err == nil {
t.Errorf("%s: expected a parse error", name)
@@ -242,6 +243,26 @@ func TestRetryRejectsBadUse(t *testing.T) {
}
}
// TestExpectChangeStep covers the wedged-app check: a delivered input that the
// app never acts on must fail with its own reason, and may re-press the step
// above a bounded number of times (FR-11).
func TestExpectChangeStep(t *testing.T) {
rec, err := Parse("steps:\n - key enter\n - expect_change 12s retry 2 else \"the app stopped accepting input\"\n")
if err != nil {
t.Fatalf("Parse: %v", err)
}
step := rec.Steps[1]
if step.Verb != "expect_change" || step.Timeout != 12*time.Second {
t.Fatalf("expect_change step = %+v", step)
}
if step.Retry != 2 || step.Reason != "the app stopped accepting input" {
t.Fatalf("retry/reason = %d / %q", step.Retry, step.Reason)
}
if len(step.Args) != 1 || step.Args[0] != "12s" {
t.Fatalf("args = %v, want the duration as the only argument", step.Args)
}
}
func TestPlayingStep(t *testing.T) {
rec, err := Parse("app: com.spotify.music\nsteps:\n - tap_row \"{query}\"\n - playing \"{query}\" 30s retry 3\n")
if err != nil {